Re: Parenthesize macros in xfs

[Jan Engelhardt]

>>>> +		swapfunc(a, b, es, swaptype)		\
>>>> +} while(0)
>>>                                           ^^
>>>Missing semicolon.
>>
>> It was missing before too. ;)
>
>No, previously it was provided at the call site.

Bad habit IMO. It does not hurt to provide it in both the macro and 
the call site, GCC can handle empty instructions.


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/