Re: [PATCH] elo: Support non-pressure-sensitive ELO touchscreens

[Dmitry Torokhov]

On Monday 27 March 2006 18:15, Shaun Jackman wrote:
> On 3/27/06, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> > We should not only omit reporting pressure if toucscreen does not
> > support it but also not set ABS_PRESSURE bit in input device.
> 
> Can I simply call input_set_abs_params and serio_set_drvdata again to
> change these bits on the fly based on the 'T' packets? What value
> should be the default before a 'T' packet has been received? I'd
> suggest no pressure.
>

No, we should not change basic input device's capabilities "on-fly" -
userspace should be able to rely on what was reported to it in the first
place. From looking over the documentation (thank you for the link)
it looks like you would need to issue 'i' command to query controller
type and whether the controller supports Z-axis in elo_connect(). 

> > What is the reason for postponing checking for 'T' until full packet
> > is assembled? Did you actually see packets with valid checksum but
> > without 'T'?
> 
> I believe the 'T' packet is the only packet that the touchscreen sends
> unrequested. However, the touch screen can send a number of other
> packets as well. The protocol documentation is available from Elo:
> 
> 	http://elotouch.com/files/manuals/smartset.zip
> 

OK, I see.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/