Re: [PATCH -mm] swsusp: support creating bigger images (rev. 2)

[Pavel Machek]

> > Too much uncertainity for 10% speedup, I'm afraid. Yes, it was really
> > clever to get this fundamental change down to few hundred lines, but
> > design complexity remains. Could we drop that patch?
> 
> Could you provide justification for your claim that the speedup is
> only 10%?

10% was number Rafael provided, IIRC.

> Please also remember that you are introducing complexity in other ways, with 
> that swap prefetching code and so on. Any comparison in speed should include 
> the time to fault back in pages that have been discarded.

Well, swap prefetching is useful for other workloads, too; so it gets
developed/tested outside swsusp.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/