Re: [PATCH 2.6.17-rc4 4/6] Add kmemleak support for i386

[Jan Engelhardt]

> [snip]
>> +static inline unsigned long arch_call_address(void *frame)
>> +{
>> +       return *(unsigned long *) (frame + 4);
>
>      return *(unsigned long *)(frame + 4);

I would like to point out that a __bulitin_return_address(immediate int) 
and __builtin_frame_address(immediate int) exist (but they can 
unfortunately not be used with variables even though that would not pose 
much of a problem on x86).


>> +static inline void *arch_prev_frame(void *frame)
>> +{
>> +       return *(void **) frame;
>
>      return *(void **)frame;
>



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/