Re: [PATCH/RFC 2.6.16.5 1/1] usb/media/quickcam_messenger driver

[Jaya Kumar]

On 5/15/06, Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> Building this data structure on the stack is a shooting offense.

I completely agree with you (except for the shooting part :-). I'll
make the corrections. In my defense, I copied that from the konicawc
code.

drivers/usb/media/konicawc.c

921 static int __init konicawc_init(void)
922 {
923         struct usbvideo_cb cbTbl;
924         info(DRIVER_DESC " " DRIVER_VERSION);
925         memset(&cbTbl, 0, sizeof(cbTbl));
926         cbTbl.probe = konicawc_probe;
927         cbTbl.setupOnOpen = konicawc_setup_on_open;
928         cbTbl.processData = konicawc_process_isoc;
929         cbTbl.getFPS = konicawc_calculate_fps;
930         cbTbl.setVideoMode = konicawc_set_video_mode;
931         cbTbl.startDataPump = konicawc_start_data;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/