Re: [PATCH/RFC 2.6.16.5 1/1] usb/media/quickcam_messenger driver

[Jaya Kumar]

On 5/15/06, Oliver Neukum <oliver@xxxxxxxxxx> wrote:
> Am Sonntag, 14. Mai 2006 16:11 schrieb jayakumar.video@xxxxxxxxx:
> > +static int qcm_setup_on_open(struct uvd *uvd)
> > +{
> > +qcm_sensor_set_gains(uvd, uvd->vpic.hue,
> > +uvd->vpic.colour, uvd->vpic.contrast);
> > +qcm_sensor_set_exposure(uvd, uvd->vpic.brightness);
> > +qcm_sensor_set_shutter(uvd, uvd->vpic.whiteness);
> > +qcm_set_camera_size(uvd);
> > +qcm_camera_on(uvd);
> > +return 0;
> > +}
>
> This function can generate IO errors. You should not simply drop them.

You are right. I was lazy about that. I'll put in a macro like
CHECK_RET(qcm_camera_on) for all the calls that do IO.

Thanks,
jaya
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/