Re: [PATCH] kthread: convert stop_machine into a kthread

From: Serge E. Hallyn
Date: Tue Jun 20 2006 - 21:44:03 EST


Quoting Andrew Morton (akpm@xxxxxxxx):
> On Tue, 20 Jun 2006 19:52:06 -0500
> "Serge E. Hallyn" <serue@xxxxxxxxxx> wrote:
>
> > here's
> > the patch I meant to send.
> >
> > ...
> >
> > -static int stopmachine(void *cpu)
> > +static int stopmachine(void)
> > ...
> > - tsk = kthread_run(stopmachine, (void *)(long)i, "stopmachine");
> > + tsk = kthread_create(stopmachine, NULL, "stopmachine");
>
> This should have spat a compiler warning.
>
> The confidence level on all of this ain't high. Please, test the patch
> which I merged?

Compiles, boots, and shuts down on s390.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/