Re: [RFC] [PATCH 2/8] inode-diet: Move i_pipe into a union

From: Theodore Tso
Date: Tue Jun 20 2006 - 21:44:18 EST


On Tue, Jun 20, 2006 at 09:23:51AM -0600, Brian F. G. Bidulock wrote:
>
> It's used for implementing STREAMS-based FIFOs. Which is a proper use
> of i_pipe (which is for FIFOs). Pipes (both mainline and STREAMS-based
> pipes) can use i_private instead of i_pipe.

It's is an abuse of i_pipe. You are using something which is supposed
to hold a struct pipe_info, and storing the head of the STREAM stack,
which is some other type.

In any case, when you state authoratively what "can" and "can not" be
combined, please specify when your justification is for a particular
out of tree modules.

- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/