Re: [i2c] [PATCH] I2C bus driver for Philips ARM boards

[Greg KH]

On Thu, Jun 22, 2006 at 03:31:46PM +0400, Vitaly Wool wrote:
> +static inline int i2c_pnx_bus_busy(volatile struct i2c_regs *master)
> +{
> +	long timeout;
> +
> +	timeout = TIMEOUT * 10000;
> +	if (timeout > 0 && (master->sts & mstatus_active)) {

Please use the proper ioread() function to read from memory, and don't
rely on a memory mapped structure.  Linux does this in order to work for
all platforms.

A big hint about this, if you have volatile in your driver, it's
wrong...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/