Re: [i2c] [PATCH] I2C bus driver for Philips ARM boards

[Greg KH]

On Fri, Jun 23, 2006 at 12:17:55AM +0400, Vitaly Wool wrote:
> On 6/22/06, Greg KH <greg@xxxxxxxxx> wrote:
> >
> >> +static inline int i2c_pnx_bus_busy(volatile struct i2c_regs *master)
> >> +{
> >> +     long timeout;
> >> +
> >> +     timeout = TIMEOUT * 10000;
> >> +     if (timeout > 0 && (master->sts & mstatus_active)) {
> >
> >A big hint about this, if you have volatile in your driver, it's
> >wrong...
> 
> 
> Well, I do remember flames on the subject... Still __raw_readl also uses
> volatile.
> Anyway, I can't disagree that ioreadX-based register access are better.
> Greg, is there anything else I should take care of before re-sending the
> patch, except for the things that you and Ben pointed out?

Not that I can think of, that would be a good starting point :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/