Re: [PATCH 4/4] Slab Reclaim logic

[Pekka J Enberg]

On Thu, 22 Jun 2006, Christoph Lameter wrote:
> > s/nr_freed/ret/
> 
> ret is non descriptive. nr_freed is describing what the purpose of the 
> variable is.
> 
> > > +	while (nr_freed < slabs_to_free) {
> > > +		int x;
> > 
> > s/x/nr_freed/
> 
> Would shadow variable.

Which is why I suggested using ret for the return variable.  Not a biggie, 
though, obviously.

				Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/