Re: [PATCH] i386: clean up user_mode() use

[Chuck Ebbert]

In-Reply-To: <20060702133718.GA27549@xxxxxxx>

On Sun, 2 Jul 2006 15:37:18 +0200, Ingo Molnar wrote:

> > to avoid such mistakes in the future, the suggested solution is to 
> > make user_mode() on i386 consistent with the generic expectation and 
> > make it detect any user mode execution context, that is, it should 
> > take the role of user_mode_vm() and a new user_mode_novm() is 
> > introduced for the i386 specific cases where v86 mode can be excluded. 
> > in short, the patch simply does a
> > 
> >   user_mode_vm -> user_mode
> >   user_mode    -> user_mode_novm
> > 
> > substitution as appropriate.
> > 
> > Signed-off-by: PaX Team <pageexec@xxxxxxxxxxx>
> 
> agreed!
> 
> Acked-by: Ingo Molnar <mingo@xxxxxxx>

Please make that second one

        user_mode_novm86

Otherwise people might think it means "user mode no virtual memory."

-- 
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/