Re: [PATCH] i386: clean up user_mode() use

[Linus Torvalds]

On Sun, 2 Jul 2006, Chuck Ebbert wrote:
> > > 
> > >   user_mode_vm -> user_mode
> > >   user_mode    -> user_mode_novm

No. Horrible.

I'm disgusted that somebody really would even consider something like 
this. It CHANGES SEMANTICS for the same name, which is a maintenance 
nightmare and a security bug. Now some patch assumes the new behaviour, 
gets back-ported, and is subtly broken.

If you want to get rid of the "user_mode()" thing, don't re-use the name 
with somethign that means something else.

Just do

	user_mode() -> user_mode_novm86()

instead, and leave the old macro entirely behind.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/