Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu)(UPDATED)

[Randy.Dunlap]

On Wed, 5 Jul 2006 23:03:37 -0400 Thomas Tuttle wrote:

> On July 05 at 23:01 EDT, Randy.Dunlap hastily scribbled:
> > On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote:
> > 
> > > Here is a new version of the patch, incorporating code style tips from
> > > Randy Dunlap <rdunlap@xxxxxxxxxxxx>, and based on 2.6.17-git25, rather
> > > than 2.6.17.1.
> > > 
> > > I noticed that there's a Heartbeat LED trigger in the git version.  I
> > > hope this isn't too similar.
> > 
> > I missed at least one thing:
> > 
> > Don't #include <linux/config.h>
> > That is done automatically now by Kbuild.  Source files
> > should not do it.  (you could wait to see if there are other comments. :)
> > 
> > ---
> > ~Randy
> 
> Are you sure?  Will it rebuild a file if a config entry is changed that
> is simply mentioned in an #ifdef?
> 
> Is this a recent change?  It wasn't working this way in 2.6.17.1--it
> automatically noticed changes to the config of the file itself, but not
> to config symbols tested using #ifdef.

Actually the Kbuild system auto. includes <linux/autoconf.h> which is
generated from config.h.  2.6.17.* should be the same.
It's been this way since last Oct. (although I can't find that
message that was just posted today [July 5]).

http://lkml.org/lkml/2006/7/5/124

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/