Re: [PATCH 4/5] PCI-Express AER implemetation: AER core andaerdriver

From: Arjan van de Ven
Date: Wed Jul 12 2006 - 09:16:13 EST


> +
> + struct semaphore rpc_sema; /*
> + * Semaphore access required to
> + * access, add, remove, or print AER
> + * aware devices in this RPC hierarchy
> + */


Hi,

sorry to bug you again.. but is there a reason you're introducing a new
semaphore and not a mutex? From looking at the code it could/should be a
mutex...

Greetings,
Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/