Re: [PATCH 4/5] PCI-Express AER implemetation: AER core andaerdriver

[Zhang, Yanmin]

On Wed, 2006-07-12 at 21:16, Arjan van de Ven wrote:
> > + 
> > +	struct semaphore rpc_sema;	/* 
> > +					 * Semaphore access required to
> > +					 * access, add, remove, or print AER
> > +				 	 * aware devices in this RPC hierarchy
> > +					 */
> 
> 
> Hi, 
> 
> sorry to bug you again..
Any comment is welcome.

>  but is there a reason you're introducing a new
> semaphore and not a mutex? From looking at the code it could/should be a
> mutex...
It could be a mutex and be deleted because every root port has its own rpc. workqueue
could guarantee only one keventd will service the work at the same time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/