Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

From: Pekka Enberg
Date: Wed Jul 19 2006 - 09:52:40 EST

On 7/19/06, Paul Mackerras <paulus@xxxxxxxxx> wrote:
> - par->mmap_map = kmalloc(j * sizeof(*par->mmap_map), GFP_ATOMIC);
> + par->mmap_map = kcalloc(j, sizeof(*par->mmap_map), GFP_ATOMIC);
> if (!par->mmap_map) {
> PRINTKE("atyfb_setup_sparc() can't alloc mmap_map\n");
> return -ENOMEM;
> }
> - memset(par->mmap_map, 0, j * sizeof(*par->mmap_map));

What exactly do we gain by using kcalloc rather than kzalloc here?
There is no potential overflow issue to worry about.

Potentially useful for kmemleak, I think. Catalin?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at