Re: [PATCH] no console disabling during suspend stage

From: Andrew Morton
Date: Fri Jul 21 2006 - 09:03:49 EST

On Wed, 19 Jul 2006 11:16:00 +0200
Rodolfo Giometti <giometti@xxxxxxxx> wrote:

> here a little patch to avoid disabling console during suspend stage
> while we are debugging kernel.
> ...
> --- kernel/power/main.c 2006-07-19 10:54:11.000000000 +0200
> +++ kernel/power/ 2006-07-18 19:38:41.000000000 +0200
> @@ -86,7 +86,9 @@
> goto Thaw;
> }
> suspend_console();
> +#endif

CONFIG_DEBUG_KERNEL is not really the appropriate thing to use here - it's
more a user-interface/Kconfig level thing.

Can you please describe the problems which suspend_console() are causing?

Some runtime knob might be more appropriate. Perhaps /sys/power/debug?

If the suspend_console() call is to be disabled then you'll want to disable
the matching resume_console() call too.

printk.c needs sem2mutex conversion.

The console_suspended/secondary_console_sem handling is racy. Bad Linus.
But as we're running on a single CPU and all other tasks are frozen it
doesn't matter.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at