Re: [PATCH 1/1] - sgiioc4: fixup use of mmio ops
From: Andrew Morton
Date: Fri Jul 21 2006 - 09:15:50 EST
On Wed, 19 Jul 2006 22:19:29 -0700
Jeremy Higdon <jeremy@xxxxxxx> wrote:
> On Wed, Jul 19, 2006 at 10:31:55AM -0500, John Keller wrote:
> > Resend #2 changes include:
> > - use 'void __iomem *' for ioremap() return values,
> > and handle error cases.
> > sgiioc4.c had been recently converted to using mmio ops.
> > There are still a few issues to cleanup.
> > Signed-off-by: jpk@xxxxxxx
> Signed-off-by: jeremy@xxxxxxx
hrm. I think we're owed a couple of iounmap()s, please. One in the
ide_dma_sgiioc4() error path and one in the takedown path.
Maybe that was one of the "few issues to cleanup", but it's a pretty simple
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/