Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

From: Tomasz Kłoczko
Date: Sat Jul 22 2006 - 16:58:52 EST

On Sat, 22 Jul 2006, Jeff Garzik wrote:

Tomasz Kłoczko wrote:
Moment .. are you want to say something like "keep commont coding style can't be maintained by tool" ?
Even if indent watches on to small coding style emenets still I don't see why using this tool isn't one of the current ement of release procedure (?).

indent isn't perfect, _especially_ where C99 comes into the picture.

Again: is in this case "isn't perfect" mean "it does not make all what we want" ? If yes still I don't see why not use indent + some other tool or if you will show real example where it does something badady (like now for checking code syntax is used compiler and some other tools like sparse).

And running indent across the tree pre-release would (a) create a ton of noise before each release, and (b) undo perfectly valid, readable formatting.

Committing all this "noise" will plug all this thing and allow reve most of content Documentation/CodingStyle document.
Is it not wort stop all questions/discuss/flames on this subject ?
Again: using indent mainly will mean only one time massive changes. After this ident can be runed for example by Linus just before make release and/or partial release.

scripts/Lindent exists and gets used, but it is not perfect.

Again: anywhere are listed/was posted list of "not perfect" examples ? And/or: what does it mean in this case "not perfect" ? Show this for allow start work on fix indent by other people (if all cases will be resul of some bugs in this tool).

*Ludzie nie mają problemów, tylko sobie sami je stwarzają*
Tomasz Kłoczko, sys adm|*e-mail: kloczek@xxxxxxxxxxxxxxxxxx*