Re: 2.6.18-rt1

[Daniel Walker]

On Wed, 2006-09-20 at 21:46 +0200, Ingo Molnar wrote:
> * Gene Heskett <gene.heskett@xxxxxxxxxxx> wrote:
> 
> > That looks like the chorus of the song I saw when it crashed on boot, 
> > pretty darned close to identical.
> 
> ok, i've uploaded -rt3:
> 
>    http://redhat.com/~mingo/realtime-preempt/
> 
> this should have this one fixed.
> 
> 	Ingo

What about the !PREEMPT_RT case.. It still wouldn't disable interrupts
in the below.. 

 
-       local_irq_save(flags);
        if (up->port.sysrq) {
                /* serial8250_handle_port() already took the lock */
                locked = 0;
        } else if (oops_in_progress) {
-               locked = spin_trylock(&up->port.lock);
+               locked = spin_trylock_irqsave(&up->port.lock, flags);
        } else
-               spin_lock(&up->port.lock);
+               spin_lock_irqsave(&up->port.lock, flags);
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/