Re: 2.6.18-rt1

[Ingo Molnar]

* Daniel Walker <dwalker@xxxxxxxxxx> wrote:

> What about the !PREEMPT_RT case.. It still wouldn't disable interrupts 
> in the below..
>
> -       local_irq_save(flags);
>         if (up->port.sysrq) {
>                 /* serial8250_handle_port() already took the lock */
>                 locked = 0;
>         } else if (oops_in_progress) {
> -               locked = spin_trylock(&up->port.lock);
> +               locked = spin_trylock_irqsave(&up->port.lock, flags);
>         } else
> -               spin_lock(&up->port.lock);
> +               spin_lock_irqsave(&up->port.lock, flags);

_irqsave disables interrupts, always did.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/