Re: [PATCH 1/2 -mm] fault-injection: safer defaults, trivialoptimization, cleanup

From: Andrew Morton
Date: Tue Nov 28 2006 - 16:39:02 EST


On Mon, 27 Nov 2006 23:44:26 -0800
Don Mullis <dwm@xxxxxxxx> wrote:

> Set /debug/fail*/* defaults supposed most likely to please a new user.
> Clamp /debug/fail*/stacktrace-depth to MAX_STACK_TRACE_DEPTH.
>
> In should_fail(), move stack-unwinding test past cheaper tests (performance
> gain not quantified). Simplify logic; eliminate goto.
> Use bool/true/false consistently.
>
> Correct and disambiguate documentation.

We'd prefer one-patch-per-concept, please. This all sounds like about
six patches.

We _could_ merge this patch as-is, but it means that when this stuff
finally hits mainline it would go in as a nice sequence of logical patches,
followed by a random thing which is splattered all over all the preceding
patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/