Re: optimalisation for strlcpy (lib/string.c)

From: Mitchell Blank Jr
Date: Sun Dec 10 2006 - 16:36:56 EST


Folkert van Heusden wrote:
> Like the other patch (by that other person), I think it is faster to not
> do a strlen first.

Debatable. You've replaced a call to the highly-optimized memcpy function
with a byte-by-byte copy. It's probably a wash performance wise (have you
benchmarked?) and is certainly less clear.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/