Re: optimalisation for strlcpy (lib/string.c)

From: Folkert van Heusden
Date: Sun Dec 10 2006 - 16:41:31 EST


> > Like the other patch (by that other person), I think it is faster to not
> > do a strlen first.
> Debatable. You've replaced a call to the highly-optimized memcpy function
> with a byte-by-byte copy. It's probably a wash performance wise (have you
> benchmarked?) and is certainly less clear.

I tested it outside the kernel.
The test source can be found here:
http://www.vanheusden.com/misc/kernel-strlcpy-opt-test.c


Folkert van Heusden

--
Feeling generous? -> http://www.vanheusden.com/wishlist.php
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/