Re: [patch] net, 8139too.c: fix netpoll deadlock

From: Francois Romieu
Date: Tue Dec 12 2006 - 16:53:35 EST


Jeff Garzik <jeff@xxxxxxxxxx> :
> Ingo Molnar wrote:
[...]
> >fix deadlock in the 8139too driver: poll handlers should never forcibly
> >enable local interrupts, because they might be used by netpoll/printk
> >from IRQ context.
>
> ACK
>
> (I'll queue it, if Linus doesn't pick it up; please CC me in the future)

I have lived with the "NAPI ->poll() handler runs in BH irq enabled context"
rule for years. Is it definitely false/dead ?

If so at least 8139cp needs the same fix.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/