Re: [patch] net, 8139too.c: fix netpoll deadlock

From: Ingo Molnar
Date: Tue Dec 12 2006 - 20:21:43 EST



* Francois Romieu <romieu@xxxxxxxxxxxxx> wrote:

> > (I'll queue it, if Linus doesn't pick it up; please CC me in the
> > future)
>
> I have lived with the "NAPI ->poll() handler runs in BH irq enabled
> context" rule for years. Is it definitely false/dead ?
>
> If so at least 8139cp needs the same fix.

hm, this isnt really about NAPI polling, but about the
netconsole/netpoll/netdump poll_controller() handler.

with netconsole, printk can be called from IRQ context (and is
frequently from IRQ context during bootup or module initialization), so
a BH rule isnt enough for them.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/