Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error

From: Russell King
Date: Mon Feb 05 2007 - 12:09:10 EST


On Mon, Feb 05, 2007 at 08:58:10AM -0800, Linus Torvalds wrote:
> On Mon, 5 Feb 2007, Ingo Molnar wrote:
> >
> > but this is /only/ practical if all (even disabled) features are visible
> > (and selectable) in the tools. They are not at the moment, so selects
> > are quite useful.
>
> More importantly, some things that *are* visible probably shouldn't be, or
> should perhaps only be in expert mode (aka "EMBEDDED").
>
> A prime example of this is all the firewall settings. I'd personally
> prefer to just select a "default firewall setup" which would be enough
> for all the normal crud, instead of seeing 50 different choices.

That also falls within my rule of "user visible symbols should not be
selected".

But... we already do something like this already and it doesn't take
a scattering of "select" to achieve. Look at fs/partitions/Kconfig
as a good example.

You get offered "Advanced partition support" as the first question.
If you say "N", you get something reasonable for your platform. If
you say "Y" you're free to choose whatever silly combination you
want, but with reasonable defaults offered.

That's something that a sprinking of select just can't do.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/