Re: [patch 3/3] mm: make read_cache_page synchronous

[Andrew Morton]

On Tue,  6 Feb 2007 09:02:33 +0100 (CET) Nick Piggin <npiggin@xxxxxxx> wrote:

> Ensure pages are uptodate after returning from read_cache_page, which allows
> us to cut out most of the filesystem-internal PageUptodate_NoLock calls.

Normally it's good to rename functions when we change their behaviour, but
I guess any missed (or out-of-tree) filesystems will just end up doing a
pointless wait_on_page_locked() and will continue to work OK, yes?

> I didn't have a great look down the call chains, but this appears to fixes 7
> possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in ecryptfs,
> 1 in jffs2, and a possible cleared data overwritten with readpage in block2mtd.
> All depending on whether the filler is async and/or can return with a !uptodate
> page.
> 
> Also, a memory leak in sys_swapon().

Separate patch?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/