Re: [PATCH] siimage: DRAC4 note

[Jeff Garzik]

Alan wrote:
> The Dell DRAC4 has some interesting features including effectively hot
> unplugging/replugging the virtual CD interface when the DRAC is reset.
> This often causes drivers/ide/siimage to panic but is ok with the rather
> smarter code in libata.
>
> Just note this fact in the driver docs.
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c linux-2.6.20-mm2/drivers/ide/pci/siimage.c
> --- linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c	2007-02-20 13:38:01.000000000 +0000
> +++ linux-2.6.20-mm2/drivers/ide/pci/siimage.c	2007-02-20 13:59:44.000000000 +0000
> @@ -26,6 +26,9 @@
>   *	If you have strange problems with nVidia chipset systems please
>   *	see the SI support documentation and update your system BIOS
>   *	if neccessary
> + *
> + *	If you are using a Dell DRAC4 you should use the libata driver
> + *	if possible.

IMO it would probably easier on all involved if the comment noted what 
you state in the patch description.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/