Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

[Blaisorblade]

On Tuesday 06 March 2007 19:32, Jeff Dike wrote:
> Fix a bunch of formatting violations in the drivers:
> 	return(n) -> return n
> 	whitespace fixes
> 	emacs formatting comment removal
> 	breaking if(foo) return(n) into two lines
>
> There are also a couple of errno use bugs:
> 	using errno in a printk when the failure put errno into a local variable
> 	saving errno after a printk, which can change it
>
> Signed-off-by: Jeff Dike <jdike@xxxxxxxxxxxxxxx>

> Index: test/arch/um/drivers/chan_user.c
> ===================================================================
> --- test.orig/arch/um/drivers/chan_user.c	2007-03-06 12:09:47.000000000
> -0500 +++ test/arch/um/drivers/chan_user.c	2007-03-06 12:10:12.000000000
> -0500 @@ -158,7 +158,7 @@ static int winch_tramp(int fd, struct tt
>  	 */
>  	err = run_helper_thread(winch_thread, &data, CLONE_FILES, &stack, 0);
>  	if(err < 0){
> -		printk("fork of winch_thread failed - errno = %d\n", errno);
> +		printk("fork of winch_thread failed - errno = %d\n", err);
>  		goto out_close;
>  	}

The second line should better say -err instead of err.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/