Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

From: Jeff Dike
Date: Wed Mar 07 2007 - 11:21:34 EST


On Tue, Mar 06, 2007 at 08:07:16PM +0100, Blaisorblade wrote:
> The second line should better say -err instead of err.

Right, patch below.

Jeff

--
Work email - jdike at linux dot intel dot com


My last formatting patch got the sign of an error wrong in a printk.

Thanks to Blaisorblade for the close look.

Signed-off-by: Jeff Dike <jdike@xxxxxxxxxxxxxxx>
--
arch/um/drivers/chan_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: test/arch/um/drivers/chan_user.c
===================================================================
--- test.orig/arch/um/drivers/chan_user.c 2007-03-06 12:10:12.000000000 -0500
+++ test/arch/um/drivers/chan_user.c 2007-03-07 11:14:12.000000000 -0500
@@ -158,7 +158,7 @@ static int winch_tramp(int fd, struct tt
*/
err = run_helper_thread(winch_thread, &data, CLONE_FILES, &stack, 0);
if(err < 0){
- printk("fork of winch_thread failed - errno = %d\n", err);
+ printk("fork of winch_thread failed - errno = %d\n", -err);
goto out_close;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/