Re: [PATCH] fix cyclades.h for x86_64 (and probably others)

[Andrew Morton]

> On Wed, 14 Mar 2007 22:57:47 +0100 Klaus Kudielka <klaus.kudielka@xxxxxxx> wrote:
> at least on x86_64 the present cyclades.h is broken due to the wrong size
> of uclong. This affects, of course, both the kernel and the user-level
> utilities. The symptom is that cyzload refuses to load the firmware.
> I also managed to freeze the machine when unloading the module.
> 
> The patch below fixes this in an architecture-independent way.
> I have tested it with 2.6.19 and the driver works fine again with a
> Cyclades-Z on an Athlon 64 X2.

Looks OK, thanks.

It would be nice as a followup patch to simply remove ucchar, uclong and
all that gunk altogether from that driver  and just use u8, u16 etc.

But if you decide to do that, please fix your email client first - it is
replacing tabs with spaces.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/