Re: [patch 3/4] split usermodehelper setup from execution

From: Randy Dunlap
Date: Tue May 08 2007 - 18:07:36 EST


On Tue, 08 May 2007 15:00:44 -0700 Jeremy Fitzhardinge wrote:

> Randy Dunlap wrote:
> > On Tue, 08 May 2007 13:51:32 -0700 Jeremy Fitzhardinge wrote:
> >
> >
> >> --- a/kernel/kmod.c
> >> +++ b/kernel/kmod.c
> >> @@ -253,11 +262,94 @@ static void __call_usermodehelper(struct
> >> }
> >>
> >> /**
> >> - * call_usermodehelper_keys - start a usermode application
> >> - * @path: pathname for the application
> >> - * @argv: null-terminated argument list
> >> - * @envp: null-terminated environment list
> >> - * @session_keyring: session keyring for process (NULL for an empty keyring)
> >> + * call_usermodehelper_setup - prepare to call a usermode helper
> >> + * @path - path to usermode executable
> >> + * @argv - arg vector for process
> >> + * @envp - environment for process
> >>
> >
> > s / - /: / above please.
> >
>
> The power of cut'n'paste makes the errors consistent, at least... Will
> fix up.

Thanks. If you point me to such foobars (in general), I'll fix them up.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/