Re: [patch 3/4] split usermodehelper setup from execution

[Rusty Russell]

On Tue, 2007-05-08 at 13:51 -0700, Jeremy Fitzhardinge wrote:
> plain text document attachment (usermodehelper-split-init.patch)
> Rather than having hundreds of variations of call_usermodehelper for
> various pieces of usermode state which could be set up, split the
> info allocation and initialization from the actual process execution.

Erk, I hadn't realized how extended call_usermodehelper had become.

call_usermodehelper_pipe()?  Erk.  Grepping... for core dumping via a
process?  Without modifying the ELF core dumper (at least) to handle
short writes?  Why not dump it in an agreed location and exec the
process with that as an arg?

When did this go in?  2.6.19... hmm, too late to rip it out I guess 8(

Anyway, I'm not sure exposing an open-ended interface wins: refactoring
internally definitely makes sense though.

Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/