Re: [PATCH 05/34] PCI: Use a weak symbol for the empty version of pcibios_add_platform_entries()

[Matthew Wilcox]

On Wed, Jul 11, 2007 at 04:31:19PM -0700, Greg Kroah-Hartman wrote:
> I'm not sure if this is going to fly, weak symbols work on the compilers I'm
> using, but whether they work for all of the affected architectures I can't say.
> I've cc'ed as many arch maintainers/lists as I could find.
> 
> But assuming they do, we can use a weak empty definition of
> pcibios_add_platform_entries() to avoid having an empty definition on every
> arch.

This seems like a regression.  We go from having an empty inline
function that gets optimised away to 0 to having a function call to a
trivial function.  And on any architecture that *does* define this,
(unless I misunderstand the GCC manual), we still include the weak
definition, thus wasting space.

I don't think this is a good use of weak functions.  It's perfectly
normal to have header files filled with empty functions.  They're even
good documentation for what an architecture might want to fill in,
rather than invent their own mechanism for doing something.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/