Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd

From: YOSHIFUJI Hideaki / 吉藤英明
Date: Wed Jul 11 2007 - 20:07:39 EST

Next message: Andrew Morton: "Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO"
Previous message: Matthew Wilcox: "Re: [PATCH 05/34] PCI: Use a weak symbol for the empty version of pcibios_add_platform_entries()"
In reply to: Greg Kroah-Hartman: "[PATCH 61/61] sysfs: add parameter "struct bin_attribute *" in .read/.write methods for sysfs binary attributes"
Next in thread: Greg KH: "Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In article <11841968512510-git-send-email-gregkh@xxxxxxx> (at Wed, 11 Jul 2007 16:31:43 -0700), Greg Kroah-Hartman <gregkh@xxxxxxx> says:

> Make sysfs_put() ignore NULL sd instead of oopsing.

I do not think this is a good idea; it is non-sense (and rather a bug)
to call "put" with NULL argument in general.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Andrew Morton: "Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO"
Previous message: Matthew Wilcox: "Re: [PATCH 05/34] PCI: Use a weak symbol for the empty version of pcibios_add_platform_entries()"
In reply to: Greg Kroah-Hartman: "[PATCH 61/61] sysfs: add parameter "struct bin_attribute *" in .read/.write methods for sysfs binary attributes"
Next in thread: Greg KH: "Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]