Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd

[Greg KH]

On Thu, Jul 12, 2007 at 08:50:47AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> In article <11841968512510-git-send-email-gregkh@xxxxxxx> (at Wed, 11 Jul 2007 16:31:43 -0700), Greg Kroah-Hartman <gregkh@xxxxxxx> says:
> 
> > Make sysfs_put() ignore NULL sd instead of oopsing.
> 
> I do not think this is a good idea; it is non-sense (and rather a bug)
> to call "put" with NULL argument in general.

It's better than having to check it all the time in the caller :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/