Re: [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1

[Avi Kivity]

Linus Torvalds wrote:
> On Sat, 14 Jul 2007, Avi Kivity wrote:
>   
> > Linus, please do your usual thing from the repository and branch at
> >     
>
> It has code like
>
> 	+       /* Can deadlock when called with interrupts disabled */
> 	+       WARN_ON(irqs_disabled());
> 	+
> 	        /* prevent preemption and reschedule on another processor */
> 	        int me = get_cpu();
>
> which is against the coding conventions (and shouldn't even compile 
> cleanly - but maybe we don't have the "warn about C99 variable 
> declarations" thng on?).
>   

It's on.  I guess I didn't notice because other changes triggered a 
recompile of the whole tree.

> Please don't do that.
>   

Fixed and rebased.  I also silenced a few warnings on the UP case by 
adding a missing #include.  It's at the same place:

 git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus

--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/