Re: block/bsg.c

[FUJITA Tomonori]

From: Jens Axboe <jens.axboe@xxxxxxxxxx>
Subject: Re: block/bsg.c
Date: Tue, 17 Jul 2007 08:38:11 +0200

> On Mon, Jul 16 2007, Andrew Morton wrote:
> > 
> > A belated review (I've never seen this before and there it is in mainline)
> > 
> > > static char bsg_version[] = "block layer sg (bsg) 0.4";
> > 
> > `const' would be better.  That moves it into a write-protected memory section.
> 
> Agree
> 
> > > #define list_entry_bc(entry)	list_entry((entry), struct bsg_command, list)
> > 
> > This makes the code easier to write but harder to read.  We should optimise
> > for readers.  Please open-code this at callsites.
> > 
> > Or at least convert it into a (commented) (possibly inlined) C function.
> 
> list_entry_to_bc(), then? The main objective is to save on typing, and
> (just as important) make sure we don't bump over the 80 chars per line.
> 
> > > /*
> > >  * just for testing
> > >  */
> > > #define BSG_MAJOR	(240)
> > 
> > What's this doing in mainline?  240 is a "reserved for local use" major. 
> > This will cause collisions.  This code should be using dynamic major
> > assignment.
> 
> Yeah, that's a big error on my part. Will get that fixed up right away.

I've been testing the patchset to fix the issues that Andrew pointed
out. I can send it soon.

Jens, have you already fixed some?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/