Re: [PATCH] smp_call_function_single() should be a macro on UP

[David Miller]

From: Al Viro <viro@xxxxxxxxxxxxxxxx>
Date: Tue, 17 Jul 2007 22:29:46 +0100

> ... or we end up with header include order problems from hell.
> E.g. on m68k this is 100% fatal - local_irq_enable() there
> wants preempt_count(), which wants task_struct fields, which
> we won't have when we are in smp.h pulled from sched.h.
> 
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>

I was going to fix the sparc64/UP build fallout by
adding linux/kernel.h include to linux/smp.h but that
definitely would not handle this m68k case at all.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/