Re: 2.6.23 compile failure - slab/slob interspanking

[Matt Mackall]

On Wed, Jul 18, 2007 at 09:18:36AM +0900, Paul Mundt wrote:
> On Tue, Jul 17, 2007 at 10:00:08PM +0200, Jan Engelhardt wrote:
> > 81cda6626178cd55297831296ba8ecedbfd8b52d is first bad commit
> > commit 81cda6626178cd55297831296ba8ecedbfd8b52d
> > Author: Christoph Lameter <clameter@xxxxxxx>
> > Date:   Tue Jul 17 04:03:29 2007 -0700
> > 
> >     Slab allocators: Cleanup zeroing allocations
> >     
> >     It becomes now easy to support the zeroing allocs with generic inline
> >     functions in slab.h.  Provide inline definitions to allow the continued use of
> >     kzalloc, kmem_cache_zalloc etc but remove other definitions of zeroing
> >     functions from the slab allocators and util.c.
> >     
> >     Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
> >     Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >     Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > 
> This fixes it for me with your .config:
> 
> slob: Kill off duplicate kzalloc() definition.
> 
> With the slab zeroing allocations cleanups Christoph stubbed in a generic
> kzalloc(), which was missed on SLOB. Follow the SLAB/SLUB changes and
> kill off the __kzalloc() wrapper that SLOB was using.

Looks fine to me.

> Reported-by: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
> Signed-off-by: Paul Mundt <lethal@xxxxxxxxxxxx>

Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/