Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 take #3

[Dmitry Torokhov]

On Tuesday 17 July 2007 14:16, Soeren Sonnenburg wrote:
> On Tue, 2007-07-17 at 11:01 -0400, Dmitry Torokhov wrote:
> > Hi,
> > 
> > On 7/17/07, Soeren Sonnenburg <kernel@xxxxxx> wrote:
> > >
> > >  err_free_buffer:
> > > @@ -656,6 +699,7 @@ static void atp_disconnect(struct usb_interface *iface)
> > >
> > >        usb_set_intfdata(iface, NULL);
> > >        if (dev) {
> > > +               cancel_work_sync(&dev->work);
> > >                usb_kill_urb(dev->urb);
> > >                input_unregister_device(dev->input);
> > >                usb_buffer_free(dev->udev, dev->datalen,
> > >
> > 
> > This should go into atp_close() and I think you need to do
> > cancel_work_sync after calling usb_kill_urb() otherwise you risk it
> > being submitted while you gettingto kill the urb.
> 
> good catch. modified patch accordingly+attached.
> 
> > How many boxes did you try this patch on?
> 
> Mine plus 1 other. However please note that Matthews patch has been
> (which is what this patch is based on) is in the mactel-patches
> repository for quite some time now and that the not-yet-cleanup up
> variant of this patch was posted to mactel-devel...
> 
> So the modeswitch part should work...
> 

OK, can I please get signed-off-bys for the latest version so I can
apply it?

Thanks!

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/