Re: [PATCH 1/3] drivers/base/core: improve device_add() error handling,fix bugs

[Jeff Garzik]

Cornelia Huck wrote:
> On Wed, 18 Jul 2007 01:53:48 -0400,
> Jeff Garzik <jeff@xxxxxxxxxx> wrote:
>
> > The following change was checked into 'warnings' branch of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
> >
> > commit 5330916f5a11d8b7def46a6b3e14a831684032f5
> > Author: Jeff Garzik <jeff@xxxxxxxxxx>
> > Date:   Wed Jul 18 01:41:29 2007 -0400
> >
> >     drivers/base/core: improve device_add() error handling, fix bugs
> >     
> >     * silence several warnings by handling sysfs_create_link() failure
> >     
> >     * re-order some operations in error handling, to precisely reverse
> >       the order of operations, i.e. unwind properly.
> >     
> >     Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>
> >
> >  drivers/base/core.c |   46 ++++++++++++++++++++++++++++++----------------
> >  1 file changed, 30 insertions(+), 16 deletions(-)
>
> Hm, what about driver-core-check-return-code-of-sysfs_create_link.patch
> (merged with ...-fix.patch) which has been in -mm for a while?

No idea, I didn't check there.   If someone else has a better patch... 
great!  Let's merge it :)

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/