Re: [PATCH][RFC] Delete export of tty.h to userspace.

[Robert P. J. Day]

On Thu, 19 Jul 2007, Karel Zak wrote:

> On Wed, Jul 18, 2007 at 04:33:12PM -0400, Robert P. J. Day wrote:
> > On Wed, 18 Jul 2007, Jiri Slaby wrote:
> >
> > > Robert P. J. Day napsal(a):
> > > >   given that the entire contents of include/linux/tty.h is contained
> > > > within an "#ifdef __KERNEL__", it seems pointless to export it to
> > > > userspace, unless there's some kind of need for that header file to
> > > > exist in userspace, even if it's empty.
> > > >
> > > >   a quick grep shows that nothing under /usr/include references any
> > > > file of the name "tty.h" in any way.  thoughts?
> > >
> > > If we decide to remove the file, I would rather go through
> > > deprecation of the file with filing an entry in
> > > feature-remove-schedule. There still seems to be some users of the
> > > file.
> >
> > i'm curious -- how did you determine that?
>
>  $ grep "tty.h" util-linux/sys-utils/cytune.c
>  #include <linux/tty.h>
>
>  ... I'll fix it in util-linux-ng.

so you're saying you'll drop that include from util-linux, is that it?
but it's still a good plan to generate a warning whenever userspace
includes that file, so i'll submit a quick patch to generate that,
based on jiri's suggestion.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/