Re: [Cbe-oss-dev] [patch 11/13] cell: driver for DDR2 memory on AXON

[Arnd Bergmann]

On Thursday 19 July 2007, Christoph Hellwig wrote:
> 
> > None of these seems to make any difference whatsoever, except for BLKBSZGET
> > returning non-zero on a ramdisk or dcssblk device. I think we'd be best
> > off removing bd_block_size from the kernel altogether, and I'll remove
> > it from the axon-ram driver now.
> 
> Yes, please.  I even have patches that only pass struct gendisk to block
> device ->open, so this couldn't work anymore anyway.  And yes, the
> ramdisk driver is doing some really odd things.

Any suggestion on what BLKBSZGET should return?

1) blocksize = 0 (same as it does already for most devices)
2) return -EINVAL
3) same as BLKSSZGET
4) return -ENOTTY

It probably doesn't matter much as any user of BLKBSZGET is
already broken, but it would be good to do the right thing
since it is a documented interface.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/