Re: [PATCH][RFC] Delete export of tty.h to userspace.

From: Jiri Slaby
Date: Thu Jul 19 2007 - 11:32:20 EST


Christoph Hellwig napsal(a):
> On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote:
>> so you're saying you'll drop that include from util-linux, is that it?
>> but it's still a good plan to generate a warning whenever userspace
>> includes that file, so i'll submit a quick patch to generate that,
>> based on jiri's suggestion.
>
> Not exporting it at all gives an error which is a lot better. Just look
> at all the warnings most userspace spews, they'd never even notice it
> otherwise.

Not directly responding to this, but keeping CCs. I though of the removal one
more time and there is one more issue (maybe). Every exported kernel header,
which includes this file outside #ifdef __KERNEL__ #endif will be broken in
userspace. Are you sure, there are no such includes?

--
Jiri Slaby (jirislaby@xxxxxxxxx)
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/