Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

[Rene Herman]

On 07/19/2007 11:47 AM, Andrew Morton wrote:

> On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx> wrote:
>
> > > Oh dear.
> > >
> > > 	ps3rom_priv(dev) = host;
> > >
> > > that's 'orrid.  We have an identifier pretending to be a function, only we
> > > go and treat it as an lvalue.
> > >
> > > I mean, C code should look like C code, and the above just doesn't.
> > >
> > > Sigh.

You could insist that it be PS3ROM_PRIV() because then it at least also 
_looks_ like cpp...

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/