Re: [PATCH 4/8] eCryptfs: Fix Tag 1 parsing code

[Michael Halcrow]

On Thu, Jul 19, 2007 at 05:41:16PM -0400, Josef Sipek wrote:
> On Thu, Jul 19, 2007 at 04:28:01PM -0500, Michael Halcrow wrote:
> > Fix up the Tag 1 parsing code to handle size limits and boundaries
> > more explicitly. Initialize the new auth_tok's flags.
> ...
> > -	if (unlikely((*packet_size) + 3 > max_packet_size)) {
> > -		ecryptfs_printk(KERN_ERR, "Packet size exceeds max\n");
> > +	if (unlikely(max_packet_size < 12)) {
> > +		printk(KERN_ERR "Invalid max packet size; must be >=12\n");
> 
> Hardcoded 12?

It's not so much a magic number if you preserve the comment
immediately above it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/