Re: [PATCH 1/8] compacting file_ra_state

[Andi Kleen]

On Fri, Jul 20, 2007 at 11:13:34PM -0700, Linus Torvalds wrote:
> > I thought the new patches were some some restructured code, but 
> > essentially the tested algorithms?
> 
> No, this series is a further cleanup on top of the restructured code, with 
> some new features too. The series _looks_ fine to me, but it still makes 
> sense to go through -mm, I think.

What I meant was:

iirc he first had a "very complex" patchkit in -mm* (the one 
with multiple predictors working together); then that got then replaced
with a simpler easier to review one and now he's feeding the stuff from
the complex one piece by piece back.

Just pointed out that the newer stuff was likely already in -mm* for some
time, just before one of the simplifications.

But I guess more testing cannot hurt anyways.

Anyways it's good we're finally making forward progress on this. It has 
the potential for real nice performance gains.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/